From 5d88599c9a6e91456af8877e80bcf492513bd52b Mon Sep 17 00:00:00 2001
From: Henry Dollman <hank@henrygd.me>
Date: Tue, 14 Jan 2025 20:31:50 -0500
Subject: [PATCH] beszel-agent-update.service: avoid non-zero exit status and
 add logging (#397)

---
 supplemental/scripts/install-agent.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/supplemental/scripts/install-agent.sh b/supplemental/scripts/install-agent.sh
index 2b8609e..61cf767 100755
--- a/supplemental/scripts/install-agent.sh
+++ b/supplemental/scripts/install-agent.sh
@@ -267,7 +267,7 @@ rm -rf "$TEMP_DIR"
 # Modify service installation part, add Alpine check before systemd service creation
 if is_alpine; then
   echo "Creating OpenRC service for Alpine Linux..."
-  cat > /etc/init.d/beszel-agent <<EOF
+  cat >/etc/init.d/beszel-agent <<EOF
 #!/sbin/openrc-run
 
 name="beszel-agent"
@@ -294,11 +294,11 @@ EOF
 
   chmod +x /etc/init.d/beszel-agent
   rc-update add beszel-agent default
-  
+
   # Create log files with proper permissions
   touch /var/log/beszel-agent.log /var/log/beszel-agent.err
   chown beszel:beszel /var/log/beszel-agent.log /var/log/beszel-agent.err
-  
+
   # Start the service
   rc-service beszel-agent restart
 
@@ -316,8 +316,8 @@ EOF
   case "$AUTO_UPDATE" in
   [Yy]*)
     echo "Setting up daily automatic updates for beszel-agent..."
-    
-    cat > /etc/init.d/beszel-agent-update <<EOF
+
+    cat >/etc/init.d/beszel-agent-update <<EOF
 #!/sbin/openrc-run
 
 name="beszel-agent-update"
@@ -393,7 +393,7 @@ Wants=beszel-agent.service
 
 [Service]
 Type=oneshot
-ExecStart=/bin/sh -c '/opt/beszel-agent/beszel-agent update | grep -q "Successfully updated" && systemctl restart beszel-agent'
+ExecStart=/bin/sh -c '/opt/beszel-agent/beszel-agent update | grep -q "Successfully updated" && (echo "Update found, restarting beszel-agent" && systemctl restart beszel-agent) || echo "No updates found"'
 EOF
 
     # Create systemd timer for the daily update