From 6e08507dde02d6a768eeee61461518bc40af32b3 Mon Sep 17 00:00:00 2001
From: Henry Dollman <hank@henrygd.me>
Date: Fri, 29 Nov 2024 17:16:40 -0500
Subject: [PATCH] remove todo comments

---
 beszel/internal/alerts/alerts.go           | 1 -
 beszel/internal/hub/config.go              | 1 -
 beszel/internal/hub/hub.go                 | 6 ++++--
 beszel/internal/users/users.go             | 4 ++--
 beszel/site/src/components/routes/home.tsx | 1 -
 5 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/beszel/internal/alerts/alerts.go b/beszel/internal/alerts/alerts.go
index 41a53ac..13d9962 100644
--- a/beszel/internal/alerts/alerts.go
+++ b/beszel/internal/alerts/alerts.go
@@ -511,7 +511,6 @@ func sliceContains(slice []string, item string) bool {
 	return false
 }
 
-// todo: test
 func (am *AlertManager) SendTestNotification(e *core.RequestEvent) error {
 	info, _ := e.RequestInfo()
 	if info.Auth == nil {
diff --git a/beszel/internal/hub/config.go b/beszel/internal/hub/config.go
index caf6f1b..7e7dfbd 100644
--- a/beszel/internal/hub/config.go
+++ b/beszel/internal/hub/config.go
@@ -210,7 +210,6 @@ func (h *Hub) getUserEmailMap(userIDs []string) (map[string]string, error) {
 // Returns the current config.yml file as a JSON object
 func (h *Hub) getYamlConfig(e *core.RequestEvent) error {
 	info, _ := e.RequestInfo()
-	// todo: test
 	if info.Auth == nil || info.Auth.GetString("role") != "admin" {
 		return apis.NewForbiddenError("Forbidden", nil)
 	}
diff --git a/beszel/internal/hub/hub.go b/beszel/internal/hub/hub.go
index d028615..fdb9125 100644
--- a/beszel/internal/hub/hub.go
+++ b/beszel/internal/hub/hub.go
@@ -80,13 +80,15 @@ func (h *Hub) Run() {
 			return err
 		}
 		// disable email auth if DISABLE_PASSWORD_AUTH env var is set
-		// todo: test email login and DISABLE_PASSWORD_AUTH env var (do we need to save usersCollection?)
 		if os.Getenv("DISABLE_PASSWORD_AUTH") == "true" {
 			usersCollection.PasswordAuth.Enabled = false
 		} else {
 			usersCollection.PasswordAuth.Enabled = true
 			usersCollection.PasswordAuth.IdentityFields = []string{"email"}
 		}
+		if err := h.app.Save(usersCollection); err != nil {
+			return err
+		}
 		// sync systems with config
 		h.syncSystemsWithConfig()
 		return se.Next()
@@ -318,7 +320,7 @@ func (h *Hub) updateSystem(record *core.Record) {
 		}
 	}
 
-	// system info alerts (todo: extra fs alerts)
+	// system info alerts
 	if err := h.am.HandleSystemAlerts(record, systemData.Info, systemData.Stats.Temperatures, systemData.Stats.ExtraFs); err != nil {
 		h.app.Logger().Error("System alerts error", "err", err.Error())
 	}
diff --git a/beszel/internal/users/users.go b/beszel/internal/users/users.go
index ac6d732..c2cfacb 100644
--- a/beszel/internal/users/users.go
+++ b/beszel/internal/users/users.go
@@ -27,7 +27,7 @@ func NewUserManager(app *pocketbase.PocketBase) *UserManager {
 	}
 }
 
-// todo: test
+// Initialize user role if not set
 func (um *UserManager) InitializeUserRole(e *core.RecordEvent) error {
 	if e.Record.GetString("role") == "" {
 		e.Record.Set("role", "user")
@@ -35,7 +35,7 @@ func (um *UserManager) InitializeUserRole(e *core.RecordEvent) error {
 	return e.Next()
 }
 
-// todo: test
+// Initialize user settings with defaults if not set
 func (um *UserManager) InitializeUserSettings(e *core.RecordEvent) error {
 	record := e.Record
 	// intialize settings with defaults
diff --git a/beszel/site/src/components/routes/home.tsx b/beszel/site/src/components/routes/home.tsx
index 419d9be..be2121f 100644
--- a/beszel/site/src/components/routes/home.tsx
+++ b/beszel/site/src/components/routes/home.tsx
@@ -18,7 +18,6 @@ export default function Home() {
 	const alerts = useStore($alerts)
 	const systems = useStore($systems)
 
-	// todo: maybe remove active alert if changed
 	const activeAlerts = useMemo(() => {
 		const activeAlerts = alerts.filter((alert) => {
 			const active = alert.triggered && alert.name in alertInfo