From 2db89355f1b0d4e962e3c8bce58ba996a3e0d208 Mon Sep 17 00:00:00 2001 From: Eric Cochran Date: Mon, 25 Sep 2017 13:05:36 -0400 Subject: [PATCH] Add CheckReturnValue for toJson's string result. This helps Error Prone and the IDE find accidental usages of toJson(value) instead of toJson(writer, value). --- moshi/src/main/java/com/squareup/moshi/JsonAdapter.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/moshi/src/main/java/com/squareup/moshi/JsonAdapter.java b/moshi/src/main/java/com/squareup/moshi/JsonAdapter.java index aee928a..43da90e 100644 --- a/moshi/src/main/java/com/squareup/moshi/JsonAdapter.java +++ b/moshi/src/main/java/com/squareup/moshi/JsonAdapter.java @@ -20,6 +20,7 @@ import java.lang.annotation.Annotation; import java.lang.reflect.Type; import java.math.BigDecimal; import java.util.Set; +import javax.annotation.CheckReturnValue; import javax.annotation.Nullable; import okio.Buffer; import okio.BufferedSink; @@ -46,7 +47,7 @@ public abstract class JsonAdapter { toJson(writer, value); } - public final String toJson(@Nullable T value) { + public final @CheckReturnValue String toJson(@Nullable T value) { Buffer buffer = new Buffer(); try { toJson(buffer, value);