From 892a4d9ca59cf01547f006f96c67a854a82a235b Mon Sep 17 00:00:00 2001 From: Sangho <114962894+sangho-block@users.noreply.github.com> Date: Tue, 28 May 2024 09:47:45 -0700 Subject: [PATCH] Remove @Synchronized annotation from `Rfc3339DateJsonAdapter`. (#1842) * Remove synchronized modifier from Rfc3339DateJsonAdapter * Added a small note to avoid regression in the future. --- .../com/squareup/moshi/adapters/Rfc3339DateJsonAdapter.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/moshi-adapters/src/main/java/com/squareup/moshi/adapters/Rfc3339DateJsonAdapter.kt b/moshi-adapters/src/main/java/com/squareup/moshi/adapters/Rfc3339DateJsonAdapter.kt index 4b3e804..5ff94fc 100644 --- a/moshi-adapters/src/main/java/com/squareup/moshi/adapters/Rfc3339DateJsonAdapter.kt +++ b/moshi-adapters/src/main/java/com/squareup/moshi/adapters/Rfc3339DateJsonAdapter.kt @@ -34,7 +34,8 @@ import java.util.Date * ``` */ public class Rfc3339DateJsonAdapter : JsonAdapter() { - @Synchronized + + /** The underlying deserialization logic is thread-safe and does not require synchronization. **/ @Throws(IOException::class) override fun fromJson(reader: JsonReader): Date? { if (reader.peek() == NULL) { @@ -44,7 +45,7 @@ public class Rfc3339DateJsonAdapter : JsonAdapter() { return string.parseIsoDate() } - @Synchronized + /*** The underlying serialization logic is thread-safe and does not require synchronization. **/ @Throws(IOException::class) override fun toJson(writer: JsonWriter, value: Date?) { if (value == null) {