fankes/moshi
2
0
Fork 0
mirror of https://github.com/fankes/moshi.git synced 2025-10-19 16:09:21 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use faster isAnnotationPresent check

Browse Source 
Followup from https://github.com/square/moshi/pull/749#discussion_r235224202
This commit is contained in:
Zac Sweers
2018-11-20 17:20:09 -08:00
parent afb82cb3e8
commit dbe7bfa15f
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
moshi/src/main/java/com/squareup/moshi/ClassJsonAdapter.java
View File

@@ -73,13 +73,18 @@ final class ClassJsonAdapter<T> extends JsonAdapter<T> {
if (Modifier.isAbstract(rawType.getModifiers())) { if (Modifier.isAbstract(rawType.getModifiers())) {
throw new IllegalArgumentException("Cannot serialize abstract class " + rawType.getName()); throw new IllegalArgumentException("Cannot serialize abstract class " + rawType.getName());
} }
for (Annotation annotation : rawType.getDeclaredAnnotations()) { try {
if ("kotlin.Metadata".equals(annotation.annotationType().getName())) { //noinspection unchecked if the Class.forName works, the cast will work.
Class<? extends Annotation> metadataClass =
(Class<? extends Annotation>) Class.forName("kotlin.Metadata");
if (rawType.isAnnotationPresent(metadataClass)) {
throw new IllegalArgumentException("Cannot serialize Kotlin type " + rawType.getName() throw new IllegalArgumentException("Cannot serialize Kotlin type " + rawType.getName()
+ ". Reflective serialization of Kotlin classes without using kotlin-reflect has " + ". Reflective serialization of Kotlin classes without using kotlin-reflect has "
+ "undefined and unexpected behavior. Please use KotlinJsonAdapter from the " + "undefined and unexpected behavior. Please use KotlinJsonAdapter from the "
+ "moshi-kotlin artifact or use code gen from the moshi-kotlin-codegen artifact."); + "moshi-kotlin artifact or use code gen from the moshi-kotlin-codegen artifact.");
} }
} catch (ClassNotFoundException ignored) {
} }
ClassFactory<Object> classFactory = ClassFactory.get(rawType); ClassFactory<Object> classFactory = ClassFactory.get(rawType);