From ffaedac610cc15bd5978eb972d761607036334f8 Mon Sep 17 00:00:00 2001 From: Zac Sweers Date: Wed, 12 Jan 2022 14:27:08 -0500 Subject: [PATCH] Don't suffix the value param when overriding (#1503) --- .../squareup/moshi/kotlin/codegen/api/AdapterGenerator.kt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/moshi-kotlin-codegen/src/main/java/com/squareup/moshi/kotlin/codegen/api/AdapterGenerator.kt b/moshi-kotlin-codegen/src/main/java/com/squareup/moshi/kotlin/codegen/api/AdapterGenerator.kt index d8c421e..00b7ee0 100644 --- a/moshi-kotlin-codegen/src/main/java/com/squareup/moshi/kotlin/codegen/api/AdapterGenerator.kt +++ b/moshi-kotlin-codegen/src/main/java/com/squareup/moshi/kotlin/codegen/api/AdapterGenerator.kt @@ -132,8 +132,11 @@ public class AdapterGenerator( JsonWriter::class ) .build() + // Don't use NameAllocator here because it will add `_` to the name since it's a keyword, and that + // results in it warning about not matching the overridden function's params. + // https://github.com/square/moshi/issues/1502 private val valueParam = ParameterSpec.builder( - nameAllocator.newName("value"), + "value", originalTypeName.copy(nullable = true) ) .build()