From 1b794b35181ca5c75fdbba4094a13eddd1848b2c Mon Sep 17 00:00:00 2001 From: agnostic-apollo Date: Sun, 31 Oct 2021 07:32:24 +0500 Subject: [PATCH] Fixed: Do not use colon character ":" in log tag since it is invalid and breaks logcat command filterspecs argument --- .../src/main/java/com/termux/shared/logger/Logger.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/termux-shared/src/main/java/com/termux/shared/logger/Logger.java b/termux-shared/src/main/java/com/termux/shared/logger/Logger.java index 6f875384..0bf094f2 100644 --- a/termux-shared/src/main/java/com/termux/shared/logger/Logger.java +++ b/termux-shared/src/main/java/com/termux/shared/logger/Logger.java @@ -450,11 +450,17 @@ public class Logger { return CURRENT_LOG_LEVEL; } + /** The colon character ":" must not exist inside the tag, otherwise the `logcat` command + * filterspecs arguments `[:priority]` will not work and will throw `Invalid filter expression` + * error. + * https://cs.android.com/android/platform/superproject/+/android-12.0.0_r4:system/logging/liblog/logprint.cpp;l=363 + * https://cs.android.com/android/platform/superproject/+/android-12.0.0_r4:system/logging/logcat/logcat.cpp;l=884 + * */ public static String getFullTag(String tag) { if (DEFAULT_LOG_TAG.equals(tag)) return tag; else - return DEFAULT_LOG_TAG + ":" + tag; + return DEFAULT_LOG_TAG + "." + tag; } public static boolean isLogLevelValid(Integer logLevel) {