From 4fd48a5aed2fa187352a64168e866db14490b44e Mon Sep 17 00:00:00 2001 From: agnostic-apollo Date: Fri, 28 Jan 2022 02:03:37 +0500 Subject: [PATCH] Fixed: Fix termux session shortcuts not working after TermuxActivity recreation The `List mSessionShortcuts = new ArrayList<>()` declaration was causing shortcuts list to be of size 0 in `TermuxTerminalViewClient.onCodePoint()` after re-creation, which resulted in session shortcuts not working. --- .../app/settings/properties/TermuxAppSharedProperties.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/termux/app/settings/properties/TermuxAppSharedProperties.java b/app/src/main/java/com/termux/app/settings/properties/TermuxAppSharedProperties.java index 3f7326af..737fdcf7 100644 --- a/app/src/main/java/com/termux/app/settings/properties/TermuxAppSharedProperties.java +++ b/app/src/main/java/com/termux/app/settings/properties/TermuxAppSharedProperties.java @@ -22,7 +22,7 @@ import java.util.Map; public class TermuxAppSharedProperties extends TermuxSharedProperties { private ExtraKeysInfo mExtraKeysInfo; - private List mSessionShortcuts = new ArrayList<>(); + private List mSessionShortcuts; private static final String LOG_TAG = "TermuxAppSharedProperties"; @@ -80,10 +80,7 @@ public class TermuxAppSharedProperties extends TermuxSharedProperties { * Set the terminal sessions shortcuts. */ private void setSessionShortcuts() { - if (mSessionShortcuts == null) - mSessionShortcuts = new ArrayList<>(); - else - mSessionShortcuts.clear(); + mSessionShortcuts = new ArrayList<>(); // The {@link TermuxPropertyConstants#MAP_SESSION_SHORTCUTS} stores the session shortcut key and action pair for (Map.Entry entry : TermuxPropertyConstants.MAP_SESSION_SHORTCUTS.entrySet()) {