From a987246bd82f668e94d180ccefbdc3518688c95c Mon Sep 17 00:00:00 2001 From: agnostic-apollo Date: Sun, 17 Oct 2021 21:59:36 +0500 Subject: [PATCH] Added: Add comment for why clearing of $TMPDIR may be skipped on termux exit --- .../main/java/com/termux/shared/shell/TermuxShellUtils.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/termux-shared/src/main/java/com/termux/shared/shell/TermuxShellUtils.java b/termux-shared/src/main/java/com/termux/shared/shell/TermuxShellUtils.java index c41ca55c..18dcc549 100644 --- a/termux-shared/src/main/java/com/termux/shared/shell/TermuxShellUtils.java +++ b/termux-shared/src/main/java/com/termux/shared/shell/TermuxShellUtils.java @@ -150,6 +150,11 @@ public class TermuxShellUtils { } public static void clearTermuxTMPDIR(boolean onlyIfExists) { + // Existence check before clearing may be required since clearDirectory() will automatically + // re-create empty directory if doesn't exist, which should not be done for things like + // termux-reset (d6eb5e35). Moreover, TMPDIR must be a directory and not a symlink, this can + // also allow users who don't want TMPDIR to be cleared automatically on termux exit, since + // it may remove files still being used by background processes (#1159). if(onlyIfExists && !FileUtils.directoryFileExists(TermuxConstants.TERMUX_TMP_PREFIX_DIR_PATH, false)) return;