From dd6cb5221d6b29eea8b82354ddeb6b22c441e0b3 Mon Sep 17 00:00:00 2001 From: Fredrik Fornwall Date: Mon, 6 Mar 2017 01:42:33 +0100 Subject: [PATCH] Work around Android < 7.0 wifi manager leak http://tools.android.com/tech-docs/lint-in-studio-2-3#TOC-WifiManager-Leak --- app/src/main/java/com/termux/app/TermuxActivity.java | 2 -- app/src/main/java/com/termux/app/TermuxService.java | 3 ++- app/src/main/java/com/termux/terminal/TerminalEmulator.java | 2 -- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/termux/app/TermuxActivity.java b/app/src/main/java/com/termux/app/TermuxActivity.java index c2a15996..dfd1dd49 100644 --- a/app/src/main/java/com/termux/app/TermuxActivity.java +++ b/app/src/main/java/com/termux/app/TermuxActivity.java @@ -49,8 +49,6 @@ import android.view.View.OnClickListener; import android.view.View.OnLongClickListener; import android.view.ViewGroup; import android.view.WindowManager; -import android.view.animation.Animation; -import android.view.animation.AnimationUtils; import android.view.inputmethod.InputMethodManager; import android.widget.AdapterView; import android.widget.AdapterView.OnItemClickListener; diff --git a/app/src/main/java/com/termux/app/TermuxService.java b/app/src/main/java/com/termux/app/TermuxService.java index c2d4eede..9f94763b 100644 --- a/app/src/main/java/com/termux/app/TermuxService.java +++ b/app/src/main/java/com/termux/app/TermuxService.java @@ -104,7 +104,8 @@ public final class TermuxService extends Service implements SessionChangedCallba mWakeLock = pm.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, EmulatorDebug.LOG_TAG); mWakeLock.acquire(); - WifiManager wm = (WifiManager) getSystemService(Context.WIFI_SERVICE); + // http://tools.android.com/tech-docs/lint-in-studio-2-3#TOC-WifiManager-Leak + WifiManager wm = (WifiManager) getApplicationContext().getSystemService(Context.WIFI_SERVICE); mWifiLock = wm.createWifiLock(WifiManager.WIFI_MODE_FULL_HIGH_PERF, EmulatorDebug.LOG_TAG); mWifiLock.acquire(); diff --git a/app/src/main/java/com/termux/terminal/TerminalEmulator.java b/app/src/main/java/com/termux/terminal/TerminalEmulator.java index f136a654..e172d38e 100644 --- a/app/src/main/java/com/termux/terminal/TerminalEmulator.java +++ b/app/src/main/java/com/termux/terminal/TerminalEmulator.java @@ -56,8 +56,6 @@ public final class TerminalEmulator { private static final int ESC_SELECT_LEFT_PAREN = 3; /** Escape processing: Have seen ESC and a character-set-select ) char */ private static final int ESC_SELECT_RIGHT_PAREN = 4; - /** Escape processing: Have seen ESC and a character-set-select + char */ - // private static final int ESC_SELECT_PLUS = 5; /** Escape processing: "ESC [" or CSI (Control Sequence Introducer). */ private static final int ESC_CSI = 6; /** Escape processing: ESC [ ? */