fankes/termux-app
2
0
Fork 0
mirror of https://github.com/fankes/termux-app.git synced 2025-09-06 02:35:19 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Changed: Do not re-set component state if current state equals new state in PackageUtils.setComponentState()

Browse Source
This commit is contained in:
agnostic-apollo
2022-06-14 04:04:09 +05:00
parent af6ac30bb1
commit e75680a884
1 changed files with 31 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
termux-shared/src/main/java/com/termux/shared/android/PackageUtils.java
View File

@@ -710,6 +710,13 @@ public class PackageUtils {
} }
/** Wrapper for {@link #setComponentState(Context, String, String, boolean, String, boolean, boolean)} with
* {@code alwaysShowToast} {@code true}. */
public static String setComponentState(@NonNull final Context context, @NonNull String packageName,
@NonNull String className, boolean newState, String toastString,
boolean showErrorMessage) {
return setComponentState(context, packageName, className, newState, toastString, showErrorMessage, true);
}
/** /**
* Enable or disable a {@link ComponentName} with a call to * Enable or disable a {@link ComponentName} with a call to
@@ -718,28 +725,46 @@ public class PackageUtils {
* @param context The {@link Context} for operations. * @param context The {@link Context} for operations.
* @param packageName The package name of the component. * @param packageName The package name of the component.
* @param className The {@link Class} name of the component. * @param className The {@link Class} name of the component.
* @param state If component should be enabled or disabled. * @param newState If component should be enabled or disabled.
* @param toastString If this is not {@code null} or empty, then a toast before setting state. * @param toastString If this is not {@code null} or empty, then a toast before setting state.
* @param showErrorMessage If an error message toast should be shown. * @param showErrorMessage If an error message toast should be shown.
* @param alwaysShowToast If toast should always be shown even if current state matches new state.
* @return Returns the errmsg if failed to set state, otherwise {@code null}. * @return Returns the errmsg if failed to set state, otherwise {@code null}.
*/ */
@Nullable @Nullable
public static String setComponentState(@NonNull final Context context, @NonNull String packageName, public static String setComponentState(@NonNull final Context context, @NonNull String packageName,
@NonNull String className, boolean state, String toastString, @NonNull String className, boolean newState, String toastString,
boolean showErrorMessage) { boolean alwaysShowToast, boolean showErrorMessage) {
try { try {
PackageManager packageManager = context.getPackageManager(); PackageManager packageManager = context.getPackageManager();
if (packageManager != null) { if (packageManager != null) {
ComponentName componentName = new ComponentName(packageName, className); if (toastString != null && alwaysShowToast) {
Logger.showToast(context, toastString, true);
toastString = null;
}
Boolean currentlyDisabled = PackageUtils.isComponentDisabled(context, packageName, className, false);
if (currentlyDisabled == null)
throw new UnsupportedOperationException("Failed to find if component currently disabled");
Boolean setState = null;
if (newState && currentlyDisabled)
setState = true;
else if (!newState && !currentlyDisabled)
setState = false;
if (setState == null) return null;
if (toastString != null) Logger.showToast(context, toastString, true); if (toastString != null) Logger.showToast(context, toastString, true);
ComponentName componentName = new ComponentName(packageName, className);
packageManager.setComponentEnabledSetting(componentName, packageManager.setComponentEnabledSetting(componentName,
state ? PackageManager.COMPONENT_ENABLED_STATE_ENABLED : PackageManager.COMPONENT_ENABLED_STATE_DISABLED, setState ? PackageManager.COMPONENT_ENABLED_STATE_ENABLED : PackageManager.COMPONENT_ENABLED_STATE_DISABLED,
PackageManager.DONT_KILL_APP); PackageManager.DONT_KILL_APP);
} }
return null; return null;
} catch (final Exception e) { } catch (final Exception e) {
String errmsg = context.getString( String errmsg = context.getString(
state ? R.string.error_enable_component_failed : R.string.error_disable_component_failed, newState ? R.string.error_enable_component_failed : R.string.error_disable_component_failed,
packageName, className) + ": " + e.getMessage(); packageName, className) + ": " + e.getMessage();
if (showErrorMessage) if (showErrorMessage)
Logger.showToast(context, errmsg, true); Logger.showToast(context, errmsg, true);