fankes/moshi
2
0
Fork 0
mirror of https://github.com/fankes/moshi.git synced 2025-10-18 15:39:22 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Do not allocate path outside conditionals

Browse Source 
It is not guaranteed to be used at this point and performs a decent amount of allocation and computation.
This commit is contained in:
Jake Wharton
2024-03-11 14:01:57 -04:00
parent be6cd87645
commit 7d51df53f5
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
moshi-adapters/src/main/java/com/squareup/moshi/adapters/EnumJsonAdapter.kt
View File

@@ -74,16 +74,15 @@ public class EnumJsonAdapter<T : Enum<T>> internal constructor(
override fun fromJson(reader: JsonReader): T? {
val index = reader.selectString(options)
if (index != -1) return constants[index]
val path = reader.path
if (!useFallbackValue) {
val name = reader.nextString()
throw JsonDataException(
"Expected one of ${nameStrings.toList()} but was $name at path $path",
"Expected one of ${nameStrings.toList()} but was $name at path ${reader.path}",
)
}
if (reader.peek() != STRING) {
throw JsonDataException(
"Expected a string but was ${reader.peek()} at path $path",
"Expected a string but was ${reader.peek()} at path ${reader.path}",
)
}
reader.skipValue()